themingengine: don't hardcode the slider lines in the theming engine
authorCosimo Cecchi <cosimoc@gnome.org>
Fri, 10 Jun 2011 17:44:51 +0000 (13:44 -0400)
committerCosimo Cecchi <cosimoc@gnome.org>
Fri, 4 May 2012 20:47:24 +0000 (16:47 -0400)
It's wrong to hardcode the slider lines here; those should be rendered
as an additional background layer using background-image if the theme
specifies so.

https://bugzilla.gnome.org/show_bug.cgi?id=652304

gtk/gtkthemingengine.c

index f3fcc2ac3d69fb35863867389beb1d23ec81f5ca..70254e3b5552cd73b4a6bc405acc3dfd14659722 100644 (file)
@@ -2153,32 +2153,8 @@ gtk_theming_engine_render_slider (GtkThemingEngine *engine,
                                   gdouble           height,
                                   GtkOrientation    orientation)
 {
-  const GtkWidgetPath *path;
-  gint thickness;
-
-  path = gtk_theming_engine_get_path (engine);
-
   gtk_theming_engine_render_background (engine, cr, x, y, width, height);
   gtk_theming_engine_render_frame (engine, cr, x, y, width, height);
-
-  /* FIXME: thickness */
-  thickness = 2;
-
-  if (gtk_widget_path_is_type (path, GTK_TYPE_SCALE))
-    {
-      if (orientation == GTK_ORIENTATION_VERTICAL)
-        gtk_theming_engine_render_line (engine, cr,
-                                        x + thickness,
-                                        y + (gint) height / 2,
-                                        x + width - thickness - 1,
-                                        y + (gint) height / 2);
-      else
-        gtk_theming_engine_render_line (engine, cr,
-                                        x + (gint) width / 2,
-                                        y + thickness,
-                                        x + (gint) width / 2,
-                                        y + height - thickness - 1);
-    }
 }
 
 static void